Don't delete the buffers that batch building writes into every frame.#17841
Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom Feb 16, 2025
Merged
Conversation
The `collect_buffers_for_phase` system tries to reuse these buffers, but its efforts are stymied by the fact that `clear_batched_gpu_instance_buffers` clears the containing hash table and therefore frees the buffers. This patch makes `clear_batched_gpu_instance_buffers` stop doing that so that the allocations can be reused.
JMS55
approved these changes
Feb 13, 2025
tychedelia
approved these changes
Feb 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
collect_buffers_for_phasesystem tries to reuse these buffers, but its efforts are stymied by the fact thatclear_batched_gpu_instance_buffersclears the containing hash table and therefore frees the buffers. This patch makesclear_batched_gpu_instance_buffersstop doing that so that the allocations can be reused.