Fix error in scene example#17799
Merged
alice-i-cecile merged 2 commits intobevyengine:mainfrom Feb 11, 2025
Merged
Conversation
mockersf
reviewed
Feb 11, 2025
| hash: 17588334858059901562, | ||
| name: "joe", | ||
| ), | ||
| "bevy_ecs::name::Name": "name", |
Member
There was a problem hiding this comment.
could you use a name that is not "name", just to avoid confusion? 🙂
mockersf
approved these changes
Feb 11, 2025
alice-i-cecile
approved these changes
Feb 11, 2025
Member
option 2 for me! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
After #16894, this example started logging errors:
Fixes #17798, this is the only actionable/unreported issue in there as far as I can tell.
Solution
Update the serialized scene with the expected format for
NameTesting
cargo run --example sceneDiscussion
This example breaks very often and we don't always catch it. It might be nice to have this scene either
Either of those would make the failures visible in the example report. Not sure which method would best suit the example.