Skip to content

make bevy math publishable#17727

Merged
alice-i-cecile merged 4 commits intobevyengine:mainfrom
mockersf:publishable-bevy_math
Feb 10, 2025
Merged

make bevy math publishable#17727
alice-i-cecile merged 4 commits intobevyengine:mainfrom
mockersf:publishable-bevy_math

Conversation

@mockersf
Copy link
Copy Markdown
Member

@mockersf mockersf commented Feb 7, 2025

Objective

  • bevy_math fails to publish because of the self dev-dependency
  • it's used to enable the approx feature in tests

Solution

  • Don't specify a version in the dev-dependency. dependencies without a version are ignored by cargo when publishing
  • Gate all the tests that depend on the approx feature so that it doesn't fail to compile when not enabled
  • Also gate an import that wasn't used without bevy_reflect

Testing

  • with at least cargo 1.84: cargo package -p bevy_math
  • cd target/package/bevy_math_* && cargo test

@mockersf mockersf added this to the 0.16 milestone Feb 9, 2025
@alice-i-cecile alice-i-cecile added C-Code-Quality A section of code that is hard to understand or change A-Math Fundamental domain-agnostic mathematical operations labels Feb 9, 2025
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Feb 10, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Feb 10, 2025
Merged via the queue into bevyengine:main with commit 4fe5776 Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Math Fundamental domain-agnostic mathematical operations C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants