Remove ExtractComponent::Out#15926
Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom Oct 16, 2024
Merged
Conversation
MiniaczQ
approved these changes
Oct 15, 2024
Contributor
MiniaczQ
left a comment
There was a problem hiding this comment.
Wasn't familiar with the trait in last PR my bad,
this looks appropriate
tychedelia
approved these changes
Oct 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
C: ExtractComponentinsertsC::Outinstead ofC, so we need to removeC::Out. cc Attempt to remove component from render world if not extracted. #15904.Solution
C->C::OutTesting
<ContrastAdaptiveSharpening as ExtractComponent>::Out = (DenoiseCas, CasUniform). Setting its strength to zero correctly removes the effect after this change.