Skip to content

fix spatial audio examples#15863

Merged
mockersf merged 2 commits intobevyengine:mainfrom
awtterpip:fix-spatial-audio-examples
Oct 13, 2024
Merged

fix spatial audio examples#15863
mockersf merged 2 commits intobevyengine:mainfrom
awtterpip:fix-spatial-audio-examples

Conversation

@awtterpip
Copy link
Copy Markdown
Contributor

Objective

Solution

  • Change Emitter components to use Stopwatch to allow the time to be tracked independently.

Testing

  • Changes were tested.
  • Run either the spatial_audio_2d or spatial_audio_3d example to test

@alice-i-cecile alice-i-cecile added A-Audio Sounds playback and modification S-Needs-Review Needs reviewer attention (from anyone!) to move forward C-Examples An addition or correction to our examples labels Oct 12, 2024
@alice-i-cecile alice-i-cecile added this to the 0.15 milestone Oct 12, 2024
Copy link
Copy Markdown
Contributor

@rparrett rparrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this one up.

@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Oct 13, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Oct 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 13, 2024
@mockersf mockersf enabled auto-merge October 13, 2024 16:54
@mockersf mockersf added this pull request to the merge queue Oct 13, 2024
Merged via the queue into bevyengine:main with commit d82d6ff Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Audio Sounds playback and modification C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

spatial_audio_2d and spatial_audio_3d examples: emitter jumps when movement is unpaused

4 participants