Skip to content

Remove thiserror from bevy_gilrs#15773

Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom
bushrat011899:ThiserrorBevyGilrs
Oct 9, 2024
Merged

Remove thiserror from bevy_gilrs#15773
alice-i-cecile merged 1 commit intobevyengine:mainfrom
bushrat011899:ThiserrorBevyGilrs

Conversation

@bushrat011899
Copy link
Copy Markdown
Contributor

@bushrat011899 bushrat011899 commented Oct 9, 2024

Objective

Solution

  • Removed thiserror from bevy_gilrs

@bushrat011899 bushrat011899 added D-Trivial Nice and easy! A great choice to get started with Bevy A-Input Player input via keyboard, mouse, gamepad, and more C-Code-Quality A section of code that is hard to understand or change S-Needs-Review Needs reviewer attention (from anyone!) to move forward X-Uncontroversial This work is generally agreed upon labels Oct 9, 2024
@bushrat011899 bushrat011899 mentioned this pull request Oct 9, 2024
Closed
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Oct 9, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Oct 9, 2024
Merged via the queue into bevyengine:main with commit c6a2411 Oct 9, 2024
@TimJentzsch TimJentzsch added the O-Embedded Weird hardware and no_std platforms label Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees

No one assigned

Labels

A-Input Player input via keyboard, mouse, gamepad, and more C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy O-Embedded Weird hardware and no_std platforms S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it X-Uncontroversial This work is generally agreed upon

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bushrat011899 @alice-i-cecile @TimJentzsch