Skip to content

Remove thiserror from bevy_time#15759

Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom
bushrat011899:ThiserrorBevyTime
Oct 9, 2024
Merged

Remove thiserror from bevy_time#15759
alice-i-cecile merged 1 commit intobevyengine:mainfrom
bushrat011899:ThiserrorBevyTime

Conversation

@bushrat011899
Copy link
Copy Markdown
Contributor

@bushrat011899 bushrat011899 commented Oct 9, 2024

Objective

Solution

  • Removed thiserror from bevy_time

Notes

thiserror actually wasn't even used in this crate.

@bushrat011899 bushrat011899 added D-Trivial Nice and easy! A great choice to get started with Bevy C-Code-Quality A section of code that is hard to understand or change A-Time Involves time keeping and reporting X-Uncontroversial This work is generally agreed upon S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Oct 9, 2024
@bushrat011899 bushrat011899 mentioned this pull request Oct 9, 2024
Closed
@tim-blackbird tim-blackbird added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Oct 9, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Oct 9, 2024
Merged via the queue into bevyengine:main with commit 6cc2322 Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tim-blackbird tim-blackbird tim-blackbird approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Time Involves time keeping and reporting C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it X-Uncontroversial This work is generally agreed upon

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bushrat011899 @tim-blackbird @alice-i-cecile