Fix meshlet materials#15755
Merged
alice-i-cecile merged 2 commits intobevyengine:mainfrom Oct 9, 2024
Merged
Conversation
ricky26
approved these changes
Oct 9, 2024
JMS55
reviewed
Oct 9, 2024
JMS55
approved these changes
Oct 9, 2024
Contributor
|
We also need to make sure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
After #15524, there are these bunny-shaped holes in rendering in the meshlet example!
This is because (1) they're using a raw asset handle instead of
MeshMaterial3d, and (2) the system that extracts mesh materials into the render world has an unnecessaryWith<Mesh3d>filter, which makes it not account for meshlets.Solution
Remove the redundant filter and use
MeshMaterial3d. The bunnies got some paint!