Migrate motion blur, TAA, SSAO, and SSR to required components#15572
Merged
alice-i-cecile merged 4 commits intobevyengine:mainfrom Oct 1, 2024
Merged
Conversation
Jondolf
commented
Oct 1, 2024
Comment on lines
+31
to
+36
| type TaaComponents = ( | ||
| TemporalAntiAliasing, | ||
| TemporalJitter, | ||
| DepthPrepass, | ||
| MotionVectorPrepass, | ||
| ); |
Contributor
Author
There was a problem hiding this comment.
This is kinda scuffed, but component removal is a bit more annoying without bundles 🤔
(of course I could also make this an actual Bundle like TemporalAntiAliasBundle too, but the properties aren't needed in this case)
Member
There was a problem hiding this comment.
It does seem like we're missing a camera.remove_with_requires::<TemporalAntiAliasing>() function in bevy_ecs
NiseVoid
approved these changes
Oct 1, 2024
cart
approved these changes
Oct 1, 2024
Member
cart
left a comment
There was a problem hiding this comment.
We definitely needs some form of remove_with_requires, but that shouldn't hold up progress here.
alice-i-cecile
approved these changes
Oct 1, 2024
robtfm
pushed a commit
to robtfm/bevy
that referenced
this pull request
Oct 4, 2024
…ngine#15572) # Objective Again, a step forward in the migration to required components: a bunch of camera rendering cormponents! Note that this does not include the camera components themselves yet, because the naming and API for `Camera` hasn't been fully decided yet. ## Solution As per the [selected proposals](https://hackmd.io/@bevy/required_components/%2FpiqD9GOdSFKZZGzzh3C7Uw): - Deprecate `MotionBlurBundle` in favor of the `MotionBlur` component - Deprecate `TemporalAntiAliasBundle` in favor of the `TemporalAntiAliasing` component - Deprecate `ScreenSpaceAmbientOcclusionBundle` in favor of the `ScreenSpaceAmbientOcclusion` component - Deprecate `ScreenSpaceReflectionsBundle` in favor of the `ScreenSpaceReflections` component --- ## Migration Guide `MotionBlurBundle`, `TemporalAntiAliasBundle`, `ScreenSpaceAmbientOcclusionBundle`, and `ScreenSpaceReflectionsBundle` have been deprecated in favor of the `MotionBlur`, `TemporalAntiAliasing`, `ScreenSpaceAmbientOcclusion`, and `ScreenSpaceReflections` components instead. Inserting them will now also insert the other components required by them automatically.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Again, a step forward in the migration to required components: a bunch of camera rendering cormponents!
Note that this does not include the camera components themselves yet, because the naming and API for
Camerahasn't been fully decided yet.Solution
As per the selected proposals:
MotionBlurBundlein favor of theMotionBlurcomponentTemporalAntiAliasBundlein favor of theTemporalAntiAliasingcomponentScreenSpaceAmbientOcclusionBundlein favor of theScreenSpaceAmbientOcclusioncomponentScreenSpaceReflectionsBundlein favor of theScreenSpaceReflectionscomponentMigration Guide
MotionBlurBundle,TemporalAntiAliasBundle,ScreenSpaceAmbientOcclusionBundle, andScreenSpaceReflectionsBundlehave been deprecated in favor of theMotionBlur,TemporalAntiAliasing,ScreenSpaceAmbientOcclusion, andScreenSpaceReflectionscomponents instead. Inserting them will now also insert the other components required by them automatically.