EntityRef/Mut get_components (immutable variants only)#15089
Merged
alice-i-cecile merged 9 commits intobevyengine:mainfrom Sep 9, 2024
Merged
EntityRef/Mut get_components (immutable variants only)#15089alice-i-cecile merged 9 commits intobevyengine:mainfrom
alice-i-cecile merged 9 commits intobevyengine:mainfrom
Conversation
Co-authored-by: Periwink <charlesbour@gmail.com>
Co-authored-by: Periwink <charlesbour@gmail.com>
alice-i-cecile
approved these changes
Sep 8, 2024
chescock
approved these changes
Sep 8, 2024
Contributor
chescock
left a comment
There was a problem hiding this comment.
Looks good!
It seems like this should have needed a safety comment somewhere explaining how it relies on ReadOnlyQueryData. Maybe there should be a safety requirement on init_fetch that the access is consistent, and that is normally discharged by calling update_component_access and having it not panic? (That shouldn't block this PR, of course.)
This was referenced Sep 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Smaller scoped version of #13375 without the
_mutvariants which currently have unsoundness issues.Solution
Same as #13375, but without the
_mutvariants.Testing
Migration Guide
FilteredEntityRef::componentstoFilteredEntityRef::accessed_componentsandFilteredEntityMut::componentstoFilteredEntityMut::accessed_components.