Sync flags in docs.yml with package.metadata.docs.rs#14734
Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom Aug 14, 2024
Merged
Sync flags in docs.yml with package.metadata.docs.rs#14734alice-i-cecile merged 1 commit intobevyengine:mainfrom
package.metadata.docs.rs#14734alice-i-cecile merged 1 commit intobevyengine:mainfrom
Conversation
package.metadata.docs.rspackage.metadata.docs.rs
alice-i-cecile
approved these changes
Aug 13, 2024
janhohenheim
approved these changes
Aug 13, 2024
BD103
approved these changes
Aug 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
This PR is a follow-up to #14703. I forgot to also add the flags from
package.metadata.docs.rsto the docs build.Solution
As discussed on Discord, I added the missing flags to
docs.yml.I also updated
rustc-argsto properly make use of the array (I think the value has to be either a space-separated string or an array of strings but not an array of space-separated strings 😆)