Skip to content

Meshable extrusions - Part 2 #13676

Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom
lynn-lumen:extrusion-meshing-2
Jun 4, 2024
Merged

Meshable extrusions - Part 2 #13676
alice-i-cecile merged 1 commit intobevyengine:mainfrom
lynn-lumen:extrusion-meshing-2

Conversation

@lynn-lumen
Copy link
Copy Markdown
Contributor

@lynn-lumen lynn-lumen commented Jun 4, 2024

Objective

Solution

  • Implemented meshing for extrusions of CircularSector, CircularSegment and Rhombus

Testing

  • The correctness of these was confirmed visually.

Additional information

Here is an image of what they look like :)

Screenshot 2024-06-04 230633

@alice-i-cecile alice-i-cecile added this to the 0.14 milestone Jun 4, 2024
@alice-i-cecile alice-i-cecile requested a review from NthTensor June 4, 2024 21:14
@alice-i-cecile alice-i-cecile added C-Feature A new feature, making something new possible A-Math Fundamental domain-agnostic mathematical operations X-Uncontroversial This work is generally agreed upon D-Straightforward Simple bug fixes and API improvements, docs, test and examples labels Jun 4, 2024
@alice-i-cecile alice-i-cecile added the S-Needs-Review Needs reviewer attention (from anyone!) to move forward label Jun 4, 2024
mweatherley
mweatherley approved these changes Jun 4, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@mweatherley mweatherley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@mweatherley mweatherley added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jun 4, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jun 4, 2024
Merged via the queue into bevyengine:main with commit 8e4e840 Jun 4, 2024
@lynn-lumen lynn-lumen mentioned this pull request Jun 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@NthTensor NthTensor Awaiting requested review from NthTensor

+1 more reviewer

@mweatherley mweatherley mweatherley approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Math Fundamental domain-agnostic mathematical operations C-Feature A new feature, making something new possible D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it X-Uncontroversial This work is generally agreed upon

Projects

None yet

Milestone

0.14

Development

Successfully merging this pull request may close these issues.

3 participants

@lynn-lumen @mweatherley @alice-i-cecile