New circular primitives: Arc2d, CircularSector, CircularSegment#13482
Merged
alice-i-cecile merged 23 commits intobevyengine:mainfrom May 23, 2024
Merged
New circular primitives: Arc2d, CircularSector, CircularSegment#13482alice-i-cecile merged 23 commits intobevyengine:mainfrom
Arc2d, CircularSector, CircularSegment#13482alice-i-cecile merged 23 commits intobevyengine:mainfrom
Conversation
This required adding a parameterizable angle for the UV mapping. It's in an enum to reduce the amount of churn if/when we add additional modes.
Change the default angle to a third of a circle, because a quarter leads to too thin of a segment. Also formatting changes in 2d_shapes.rs.
There were bugs.
Also draw bounding boxes on the mesh example to visually confirm correctness.
Every suggestion for the boolean condition is less readable.
Co-authored-by: Joona Aalto <jondolf.dev@gmail.com> Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
Contributor
|
The generated |
Contributor
|
Thanks for adopting this! |
alice-i-cecile
approved these changes
May 23, 2024
Member
alice-i-cecile
left a comment
There was a problem hiding this comment.
Excellent, thanks for tackling this :) I'm happy with the state of this now, and pleased to see this picked up.
mweatherley
approved these changes
May 23, 2024
Contributor
mweatherley
left a comment
There was a problem hiding this comment.
Gave this a good look before, and it looks like it works as expected! Thanks again!
41 tasks
Member
|
Thank you to everyone involved with the authoring or reviewing of this PR! This work is relatively important and needs release notes! Head over to bevyengine/bevy-website#1325 if you'd like to help out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Adopted #11748
Solution
I've rebased on main to fix the merge conflicts.
Not quite ready to merge yetThe new shapes inNever mind, looks like radians and degrees just got mixed up at some point?examples/2d/2d_shapes.rsdon't look right at all