Skip to content

asset throttling: don't be exhausted if there is no limit#13112

Merged
mockersf merged 1 commit intobevyengine:mainfrom
mockersf:dont-be-exhausted
Apr 27, 2024
Merged

asset throttling: don't be exhausted if there is no limit#13112
mockersf merged 1 commit intobevyengine:mainfrom
mockersf:dont-be-exhausted

Conversation

@mockersf
Copy link
Copy Markdown
Member

@mockersf mockersf commented Apr 27, 2024

Objective

thread 'Compute Task Pool (2)' panicked at examples/shader/compute_shader_game_of_life.rs:137:65:
called `Option::unwrap()` on a `None` value
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Encountered a panic in system `compute_shader_game_of_life::prepare_bind_group`!
thread '<unnamed>' panicked at examples/shader/compute_shader_game_of_life.rs:254:34:
Requested resource compute_shader_game_of_life::GameOfLifeImageBindGroups does not exist in the `World`.
                Did you forget to add it using `app.insert_resource` / `app.init_resource`?
                Resources are also implicitly added via `app.add_event`,
                and can be added by plugins.
Encountered a panic in system `bevy_render::renderer::render_system`!

Solution

  • exhausted() now checks that there is a limit

@mockersf mockersf added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen labels Apr 27, 2024
@mockersf mockersf added this to the 0.14 milestone Apr 27, 2024
@mockersf mockersf requested a review from robtfm April 27, 2024 01:07
@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Apr 27, 2024
@mockersf mockersf added this pull request to the merge queue Apr 27, 2024
Merged via the queue into bevyengine:main with commit 22d605c Apr 27, 2024
@mockersf mockersf deleted the dont-be-exhausted branch May 17, 2024 21:15
@mockersf mockersf restored the dont-be-exhausted branch May 17, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants