bevy_color::Color convenience methods#12171
Merged
alice-i-cecile merged 3 commits intobevyengine:mainfrom Feb 28, 2024
Merged
Conversation
This was referenced Feb 27, 2024
bushrat011899
approved these changes
Feb 28, 2024
pablo-lua
approved these changes
Feb 28, 2024
Contributor
pablo-lua
left a comment
There was a problem hiding this comment.
Nice little const methods, for sure will make the migration easier
Member
Author
|
Thanks for the quick reviews! Now I can go rebase #12163 on this and use it :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
As suggested in #12163 by @cart, we should add convenience constructors to
bevy_color::Colorto match the existing API (easing migration pain) and generally improve ergonomics.Solution
const fn Color::rgba(red, green, blue, alpha)and friends, which directly construct the appropriate variant.const fn Color::rgb(red, green, blue)and friends, which impute and alpha value of 1.0.const BLACK, WHITE, NONEtoColor. These are stored inLinearRgbato reduce pointless conversion costs and inaccuracy.ColorfromSrgba::WHITEto the new linear equivalent for the same reason.