Add Rounded box gizmos#11948
Merged
alice-i-cecile merged 18 commits intobevyengine:mainfrom May 16, 2024
Merged
Conversation
JMS55
approved these changes
Apr 25, 2024
Contributor
JMS55
left a comment
There was a problem hiding this comment.
Never reviewed gizmo stuff before, but lgtm.
Co-authored-by: JMS55 <47158642+JMS55@users.noreply.github.com>
jgayfer
approved these changes
May 1, 2024
Contributor
jgayfer
left a comment
There was a problem hiding this comment.
Not a Gizmo export by any means, but ran the examples and overall looks good to me.
Could be nice to pull that default into a constant, but not blocking.
Co-Authored-By: James Gayfer <10660608+jgayfer@users.noreply.github.com>
jgayfer
approved these changes
May 3, 2024
alice-i-cecile
approved these changes
May 16, 2024
Member
|
Thank you to everyone involved with the authoring or reviewing of this PR! This work is relatively important and needs release notes! Head over to bevyengine/bevy-website#1315 if you'd like to help out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Gizmos::rounded_cuboid,Gizmos::rounded_rectandGizmos::rounded_rect_2d..corner_radius(...)or.edge_radius(...)as well as the line segments of each arc using.arc_segments(...).Changelog
rounded_boxmodule tobevy_gizmoscontaining all of the above methods and builders.2d_gizmosand3d_gizmosAdditional information
The 3d example now looks like this:
And this is the updated 2d example showcasing negative corner radius: