Skip to content

Add double end arrow to gizmos#11890

Merged
alice-i-cecile merged 18 commits intobevyengine:mainfrom
pablo-lua:double-end-arrow
Apr 16, 2024
Merged

Add double end arrow to gizmos#11890
alice-i-cecile merged 18 commits intobevyengine:mainfrom
pablo-lua:double-end-arrow

Conversation

@pablo-lua
Copy link
Copy Markdown
Contributor

@pablo-lua pablo-lua commented Feb 16, 2024 •
edited
Loading

Objective

Solution

  • Creation of new field and method to the ArrowBuilder

Changelog

Added

  • New field ArrowBuilder::double_ended
  • New method ArrowBuilder::with_double_end to redefine the double_ended field

Additional

I added this in the 3d_gizmos example, that's the result:

image

I added this arrow in the 2d_gizmos example too:

image

afonsolage
afonsolage reviewed Feb 16, 2024
View reviewed changes
afonsolage
afonsolage reviewed Feb 16, 2024
View reviewed changes
afonsolage
afonsolage suggested changes Feb 16, 2024
View reviewed changes
afonsolage
afonsolage suggested changes Feb 16, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@afonsolage afonsolage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code seems fine, only small changes and I think the 3d example doesn't showcase well the double ended gizmos.

@Kanabenki Kanabenki added C-Feature A new feature, making something new possible A-Gizmos Visual editor and debug gizmos labels Feb 16, 2024
pablo-lua and others added 4 commits February 16, 2024 09:46
@pablo-lua @afonsolage
[style] Removed unnecessary code
c174dfc 
Co-authored-by: Afonso Lage <lage.afonso@gmail.com>
@pablo-lua @afonsolage
[style] Remove unnecessary code in example
8dfd3d1 
Co-authored-by: Afonso Lage <lage.afonso@gmail.com>
@pablo-lua @afonsolage
[rem] Remove unnecessary comment
59edb63 
Co-authored-by: Afonso Lage <lage.afonso@gmail.com>
[alt] Changed arrow position and color
eabf3af
@pablo-lua
Copy link
Copy Markdown
Contributor Author

pablo-lua commented Feb 16, 2024

I changed the arrow position in the example, it is like the image now.

@nicopap nicopap mentioned this pull request Feb 20, 2024
Open
57 tasks
lynn-lumen
lynn-lumen reviewed Apr 9, 2024
View reviewed changes
@pablo-lua pablo-lua added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Apr 9, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Apr 16, 2024
Merged via the queue into bevyengine:main with commit 6b0e3fa Apr 16, 2024
@pablo-lua pablo-lua deleted the double-end-arrow branch April 16, 2024 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

+2 more reviewers

@lynn-lumen lynn-lumen lynn-lumen approved these changes

@afonsolage afonsolage afonsolage approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Gizmos Visual editor and debug gizmos C-Feature A new feature, making something new possible S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pablo-lua @afonsolage @alice-i-cecile @lynn-lumen @Kanabenki