Skip to content

Don't try to create a uniform buffer for light probes if there are no views.#11751

Merged
mockersf merged 1 commit intobevyengine:mainfrom
pcwalton:irradiance-volumes-panic-fix
Feb 7, 2024
Merged

Don't try to create a uniform buffer for light probes if there are no views.#11751
mockersf merged 1 commit intobevyengine:mainfrom
pcwalton:irradiance-volumes-panic-fix

Conversation

@pcwalton
Copy link
Copy Markdown
Contributor

@pcwalton pcwalton commented Feb 7, 2024

Don't try to create a uniform buffer for light probes if there are no views.

Fixes the panic on examples that have no views, such as touch_input_events.

views.

Fixes the panic on examples that have no views, such as
`touch_input_events`.
@pcwalton pcwalton marked this pull request as ready for review February 7, 2024 03:54
@pcwalton pcwalton requested a review from mockersf February 7, 2024 03:54
@alice-i-cecile alice-i-cecile added this to the 0.13 milestone Feb 7, 2024
@ghost
Copy link
Copy Markdown

ghost commented Feb 7, 2024

I can confirm this resolves the crash I was getting with only a 2d camera active.

@ghost ghost added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen labels Feb 7, 2024
@pcwalton pcwalton added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Feb 7, 2024
@mockersf mockersf added this pull request to the merge queue Feb 7, 2024
Merged via the queue into bevyengine:main with commit f514d5c Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants