Skip to content

fix create_surfaces system ordering#11747

Merged
james7132 merged 2 commits intobevyengine:mainfrom
mockersf:fix-surface-creation-system-ordering
Feb 6, 2024
Merged

fix create_surfaces system ordering#11747
james7132 merged 2 commits intobevyengine:mainfrom
mockersf:fix-surface-creation-system-ordering

Conversation

@mockersf
Copy link
Copy Markdown
Member

@mockersf mockersf commented Feb 6, 2024

Objective

  • System create_surfaces needs to happen before prepare_windows or we lose one frame at startup

Solution

  • Specify the ordering, remove the set as it doesn't mean anything there

@mockersf mockersf added A-Rendering Drawing game state to the screen A-Windowing Platform-agnostic interface layer to run your app in labels Feb 6, 2024
@mockersf
Copy link
Copy Markdown
Member Author

mockersf commented Feb 6, 2024

messed it up twice in two different PRs, this time it should be good 🤦

@mockersf mockersf added this to the 0.13 milestone Feb 6, 2024
@alice-i-cecile alice-i-cecile added the C-Bug An unexpected or incorrect behavior label Feb 6, 2024
@james7132 james7132 enabled auto-merge February 6, 2024 22:44
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Feb 6, 2024
@james7132 james7132 added this pull request to the merge queue Feb 6, 2024
Merged via the queue into bevyengine:main with commit 75d383f Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Rendering Drawing game state to the screen A-Windowing Platform-agnostic interface layer to run your app in C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants