Skip to content

Batch skinned meshes#11633

Open
tygyh wants to merge 3 commits intobevyengine:mainfrom
tygyh:batch-skinned-meshes
Open

Batch skinned meshes#11633
tygyh wants to merge 3 commits intobevyengine:mainfrom
tygyh:batch-skinned-meshes

Conversation

@tygyh
Copy link
Copy Markdown
Contributor

@tygyh tygyh commented Jan 31, 2024

Objective

Solution

  • Rebase and solve change conflicts.

@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Performance A change motivated by improving speed, memory usage or compile times A-Animation Make things move and change over time labels Jan 31, 2024
@re0312
Copy link
Copy Markdown
Contributor

re0312 commented Feb 1, 2024

seems broken in window, cargo run --release --example many_foxes get panic,

thread 'Compute Task Pool (1)' panicked at C:\Users\27135\.cargo\registry\src\index.crates.io-6f17d22bba15001f\wgpu-0.19.1\src\backend\wgpu_core.rs:3009:5:
wgpu error: Validation Error

Caused by:
    In Device::create_bind_group
      note: label = `skinned_mesh_bind_group`
    Buffer usage is BufferUsages(COPY_DST | STORAGE) which does not contain required usage BufferUsages(UNIFORM)

@tygyh
Copy link
Copy Markdown
Contributor Author

tygyh commented Feb 1, 2024

seems broken in window, cargo run --release --example many_foxes get panic,

Yes, I believe the problem has to do with the if statement in the skinning function in mesh_bindings.rs. I do not know how to fix it though.

@Elabajaba
Copy link
Copy Markdown
Contributor

I got it compiling, but now it's complaining because mesh from the let skin_index = mesh[vertex_no_morph.instance_index].skin_index; in the shaders doesn't exist.

@tygyh tygyh force-pushed the batch-skinned-meshes branch 2 times, most recently from e2e1b8d to bfefbcd Compare February 15, 2024 19:06
@tygyh tygyh force-pushed the batch-skinned-meshes branch 2 times, most recently from 00ae669 to 6accf5d Compare February 27, 2024 14:37
@re0312
Copy link
Copy Markdown
Contributor

re0312 commented Mar 17, 2024

What the state of this pr ,It seems still can not work correctly now, Could I try to finish this pr ?

@tygyh
Copy link
Copy Markdown
Contributor Author

tygyh commented Mar 17, 2024

@re0312 Go right ahead

@re0312
Copy link
Copy Markdown
Contributor

re0312 commented Mar 17, 2024

@re0312 Go right ahead

I fixed some errors and tested this pr on windows and web ,but I can not push my code to your branch(I must have done something wrong and i have no idea how to resolve it) ,Could you please pull my code from my forked branch into current pr or should I open a new pr?

@tygyh tygyh force-pushed the batch-skinned-meshes branch from 151be13 to 116f8a8 Compare March 18, 2024 12:18
@tygyh tygyh force-pushed the batch-skinned-meshes branch from 116f8a8 to 02621e1 Compare March 18, 2024 12:21
@BenjaminBrienen BenjaminBrienen added S-Needs-Review Needs reviewer attention (from anyone!) to move forward D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes D-Shaders This code uses GPU shader languages labels May 16, 2025
@IQuick143 IQuick143 added the S-Adopt-Me The original PR author has no intent to complete this work. Pick me up! label May 16, 2025
@thomasza92
Copy link
Copy Markdown

Anyone working on this? I think this could give a decent performance boost for something I am messing with 👀

@tygyh
Copy link
Copy Markdown
Contributor Author

tygyh commented Dec 18, 2025

Anyone working on this?

Go right ahead

@thomasza92
Copy link
Copy Markdown

Woops, it looks like maybe I was mistaken and this is finished already?

#16599

@cart cart added this to Animation Feb 12, 2026
@github-project-automation github-project-automation bot moved this to Needs SME Triage in Animation Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Animation Make things move and change over time A-Rendering Drawing game state to the screen C-Performance A change motivated by improving speed, memory usage or compile times D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes D-Shaders This code uses GPU shader languages S-Adopt-Me The original PR author has no intent to complete this work. Pick me up! S-Needs-Review Needs reviewer attention (from anyone!) to move forward

Projects

Status: Needs SME Triage
Status: No status

Development

Successfully merging this pull request may close these issues.

10 participants