move once from bevy_log to bevy_utils, to allow for it's use in bevy_ecs#11419
Merged
mockersf merged 3 commits intobevyengine:mainfrom Jan 19, 2024
Merged
move once from bevy_log to bevy_utils, to allow for it's use in bevy_ecs#11419mockersf merged 3 commits intobevyengine:mainfrom
mockersf merged 3 commits intobevyengine:mainfrom
Conversation
alice-i-cecile
approved these changes
Jan 19, 2024
Merged
Member
|
Merging as trivial :) This has come up before, and others were in favor. This also isn't a breaking change currently since we haven't made a release. |
auto-merge was automatically disabled
January 19, 2024 00:17
Head branch was pushed to by a user without write access
Contributor
Author
|
@alice-i-cecile - had to fix the docs, so merge was disabled |
mockersf
approved these changes
Jan 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
When working within
bevy_ecs, we can't use thelog_oncemacros due to their placement inbevy_log- which depends onbevy_ecs. All this create does is migrate those macros to thebevy_utilscrate, while still re-exporting them inbevy_log.created to resolve this: #11417 (comment)