Use WindowBuilder::with_append() to append canvas#11065
Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom Dec 24, 2023
Merged
Use WindowBuilder::with_append() to append canvas#11065alice-i-cecile merged 1 commit intobevyengine:mainfrom
WindowBuilder::with_append() to append canvas#11065alice-i-cecile merged 1 commit intobevyengine:mainfrom
Conversation
mockersf
approved these changes
Dec 22, 2023
matiqo15
approved these changes
Dec 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Replace the canvas appending code with a simpler version provided by Winit v0.29.
Related: #11052.
Solution
Use
WindowBuilder::with_append().