Explain OrthographicProjection.scale#11023
Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom Jan 8, 2024
Merged
Conversation
Contributor
Author
|
CC @doonv |
doonv
suggested changes
Dec 20, 2023
786c810 to
b62c8e1
Compare
doonv
approved these changes
Dec 20, 2023
Contributor
doonv
left a comment
There was a problem hiding this comment.
Looks good, but someone else also mentioned a small improvement.
b62c8e1 to
1d434bf
Compare
Contributor
Author
|
I accidentally reset review accepted flag by @doonv. |
doonv
approved these changes
Dec 21, 2023
DanielJin21
approved these changes
Dec 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #11022.
(Also remove "in world units", it is probably a mistake.)