-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Run bevy_ecs in miri on CI #1529
Copy link
Copy link
Closed
Labels
A-Build-SystemRelated to build systems or continuous integrationRelated to build systems or continuous integrationA-ECSEntities, components, systems, and eventsEntities, components, systems, and eventsC-Code-QualityA section of code that is hard to understand or changeA section of code that is hard to understand or change
Description
What problem does this solve or what need does it fill?
Bevy_ecs contains a lot of unsafe code. Unsafe code in Bevy has been proven to be unsound on multiple occasions.
What solution would you like?
Run the bevy_ecs test suite in miri to detect UB. Preferably miri would also manually be run on #1525 before it is merged.
What alternative(s) have you considered?
- Remove all unsafe code.
- Will regress performance by a lot.
- Formally verify all unsafe code.
- Way too much work.
- Manually verify all unsafe code.
- Takes a lot of time and will miss some unsoundness.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-Build-SystemRelated to build systems or continuous integrationRelated to build systems or continuous integrationA-ECSEntities, components, systems, and eventsEntities, components, systems, and eventsC-Code-QualityA section of code that is hard to understand or changeA section of code that is hard to understand or change