-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Follow-up: Make bevy_math's ops public (and document the methods) #14796
Copy link
Copy link
Closed
Labels
A-MathFundamental domain-agnostic mathematical operationsFundamental domain-agnostic mathematical operationsC-DocsAn addition or correction to our documentationAn addition or correction to our documentationC-FeatureA new feature, making something new possibleA new feature, making something new possibleD-StraightforwardSimple bug fixes and API improvements, docs, test and examplesSimple bug fixes and API improvements, docs, test and examplesS-Ready-For-ImplementationThis issue is ready for an implementation PR. Go for it!This issue is ready for an implementation PR. Go for it!X-UncontroversialThis work is generally agreed uponThis work is generally agreed upon
Description
#14693 introduced the bevy_math::ops module, which allows bevy_math to avoid using the Rust standard floating point functions with unspecified precision. Based on comments there, it seems that making the module public to allow library authors downstream of bevy_math to do the same (for the sake of platform-agnostic determinism in floating point operations) would be desirable, so we should probably do that.
f64 versions of the operations could also be introduced in a PR that addresses this, but that part could also be left to a follow-up — on the other hand, the f64 versions are not useful internally in bevy_math, so they should probably be introduced once the module is already public.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-MathFundamental domain-agnostic mathematical operationsFundamental domain-agnostic mathematical operationsC-DocsAn addition or correction to our documentationAn addition or correction to our documentationC-FeatureA new feature, making something new possibleA new feature, making something new possibleD-StraightforwardSimple bug fixes and API improvements, docs, test and examplesSimple bug fixes and API improvements, docs, test and examplesS-Ready-For-ImplementationThis issue is ready for an implementation PR. Go for it!This issue is ready for an implementation PR. Go for it!X-UncontroversialThis work is generally agreed uponThis work is generally agreed upon