-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
FilteredEntityRef/FilteredEntityMut's access is empty when used in composite queries #14349
Copy link
Copy link
Closed
Labels
A-ECSEntities, components, systems, and eventsEntities, components, systems, and eventsC-BugAn unexpected or incorrect behaviorAn unexpected or incorrect behaviorC-UsabilityA targeted quality-of-life change that makes Bevy easier to useA targeted quality-of-life change that makes Bevy easier to useD-StraightforwardSimple bug fixes and API improvements, docs, test and examplesSimple bug fixes and API improvements, docs, test and examplesS-Ready-For-ImplementationThis issue is ready for an implementation PR. Go for it!This issue is ready for an implementation PR. Go for it!X-UncontroversialThis work is generally agreed uponThis work is generally agreed upon
Metadata
Metadata
Assignees
Labels
A-ECSEntities, components, systems, and eventsEntities, components, systems, and eventsC-BugAn unexpected or incorrect behaviorAn unexpected or incorrect behaviorC-UsabilityA targeted quality-of-life change that makes Bevy easier to useA targeted quality-of-life change that makes Bevy easier to useD-StraightforwardSimple bug fixes and API improvements, docs, test and examplesSimple bug fixes and API improvements, docs, test and examplesS-Ready-For-ImplementationThis issue is ready for an implementation PR. Go for it!This issue is ready for an implementation PR. Go for it!X-UncontroversialThis work is generally agreed uponThis work is generally agreed upon
Bevy version
Both 0.14.0 and af865e7
What you did
What went wrong
It seems that when
FilteredEntityRef/FilteredEntityMutare nested inside a tuple the access is not properly set. Indeed the implementation ofWorldQueryfor tuples does not call theset_accessmethod used byFilteredEntityRef/FilteredEntityMut. However the fix doesn't seem as simple as just calling it, since may ignore any potential conflict between theFilteredEntity*and the otherQueryDatas in the query.