Merged
Conversation
…art, complain when a MAC can't be found (UDP thing doesn't always work)
evilsocket
reviewed
Jun 10, 2022
| "Leave empty to intercept any source address.")) | ||
|
|
||
| mod.AddParam(session.NewStringParameter("any.proxy.dst_address", | ||
| session.ParamIfaceAddress, |
Member
There was a problem hiding this comment.
hey @BenGardiner can't we just leave the IPv4 default? it's just more convenient for the vast majority of the cases ... what do you think?
Contributor
Author
There was a problem hiding this comment.
yup @evilsocket , good call. I think the important change was removing the IPV4 validator and this was collateral damage when I was editing.
Member
There was a problem hiding this comment.
great! can you update the PR or do you prefer if I do it post merge?
Contributor
Author
There was a problem hiding this comment.
I did an online edit to the branch. hopefully that didn't break anything
Member
There was a problem hiding this comment.
thank you very much! merging 👍🏻
evilsocket
approved these changes
Jun 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changes to get any.proxy working in a IPV6-only & link-local-only setup