Remove --update and replace with --no-cache for apk in Dockerfile#913
Merged
evilsocket merged 1 commit intobettercap:masterfrom Nov 29, 2021
Merged
Conversation
There is no need to use `--update` with `--no-cache`, only `--no-cache` should be used when building a Docker image, as using `--no-cache` will fetch the index every time and leave no local cache, so the index will always be the latest and without temporary files remains in the image.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no need to use
--updatewith--no-cache, only--no-cacheshould be used when building a Docker image, as using
--no-cachewillfetch the index every time and leave no local cache, so the index will
always be the latest and without temporary files remains in the image.
This change will also make the usage more consistent in the Dockerfile.