Skip to content

Bump golang.org/x/net for Go 1.23 compatibility#1107

Merged
evilsocket merged 1 commit intobettercap:masterfrom
stefanb:go1.23-support
Aug 7, 2024
Merged

Bump golang.org/x/net for Go 1.23 compatibility#1107
evilsocket merged 1 commit intobettercap:masterfrom
stefanb:go1.23-support

Conversation

@stefanb
Copy link
Contributor

@stefanb stefanb commented Jun 30, 2024

Ran just

$ go get -u golang.org/x/net && go mod tidy

so that build succeeds:

$ GO=go1.23rc1 make
go1.23rc1 build -o bettercap .

Fixes #1106
Closes #1018

Diff: golang/net@60bc85c...v0.26.0
Please tag a release afterwards.

@evilsocket
Copy link
Member

@stefanb won't this affect builds with prior versions? i'm asking because to this day go 1.23 is still considered unstable.

@stefanb
Copy link
Contributor Author

stefanb commented Aug 7, 2024

@evilsocket, no it shouldn't affect building with older/current Go versions as golang.org/x/net is backwards compatible, but feel free to try it.

@evilsocket evilsocket merged commit 7371a85 into bettercap:master Aug 7, 2024
@stefanb stefanb deleted the go1.23-support branch August 7, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Build fails with Go 1.23

2 participants