chore: re-export necessary types in client plugins#6230
chore: re-export necessary types in client plugins#6230himself65 merged 7 commits intobetter-auth:canaryfrom
Conversation
|
@jslno is attempting to deploy a commit to the better-auth Team on Vercel. A member of the Team first needs to authorize it. |
better-auth
@better-auth/cli
@better-auth/core
@better-auth/expo
@better-auth/passkey
@better-auth/scim
@better-auth/sso
@better-auth/stripe
@better-auth/telemetry
commit: |
There was a problem hiding this comment.
Pull request overview
This PR adds a type-only re-export of the two-factor plugin types in the client plugins index file. This makes two-factor-related TypeScript types (such as TwoFactorOptions, UserWithTwoFactor, TwoFactorTable, and error codes) available for type inference when using Better Auth client plugins, following the same pattern used for other necessary re-exports in the codebase.
Key Changes
- Added
export type * from "../../plugins/two-factor";to the "Necessary re-exports" section of the client plugins index
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
1 issue found across 11 files (reviewed changes from recent commits).
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="packages/better-auth/src/plugins/admin/client.ts">
<violation number="1" location="packages/better-auth/src/plugins/admin/client.ts:95">
Changing the `./access` re-export to `export type *` drops all runtime helpers (defaultStatements/adminAc/userAc/etc.) that this module previously exposed, breaking consumers that import them from the admin client.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
Fixes: #6227