fix: type annotation issue#5651
Merged
himself65 merged 1 commit intobetter-auth:mainfrom Oct 28, 2025
Merged
Conversation
|
@himself65 is attempting to deploy a commit to the better-auth Team on Vercel. A member of the Team first needs to authorize it. |
better-auth
@better-auth/cli
@better-auth/core
@better-auth/expo
@better-auth/sso
@better-auth/stripe
@better-auth/telemetry
commit: |
Contributor
There was a problem hiding this comment.
1 issue found across 40 files
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="packages/core/package.json">
<violation number="1" location="packages/core/package.json:6">
Changing the "main" entry to the ESM file means CommonJS consumers that still rely on "main" will now receive an ESM module and throw ERR_REQUIRE_ESM. Please keep "main" pointing to the CommonJS bundle while "module"/exports cover the ESM path.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
packages/core/package.json
Outdated
| "type": "module", | ||
| "main": "./dist/index.cjs", | ||
| "module": "./dist/index.mjs", | ||
| "main": "./dist/index.js", |
Contributor
There was a problem hiding this comment.
Changing the "main" entry to the ESM file means CommonJS consumers that still rely on "main" will now receive an ESM module and throw ERR_REQUIRE_ESM. Please keep "main" pointing to the CommonJS bundle while "module"/exports cover the ESM path.
Prompt for AI agents
Address the following comment on packages/core/package.json at line 6:
<comment>Changing the "main" entry to the ESM file means CommonJS consumers that still rely on "main" will now receive an ESM module and throw ERR_REQUIRE_ESM. Please keep "main" pointing to the CommonJS bundle while "module"/exports cover the ESM path.</comment>
<file context>
@@ -3,103 +3,113 @@
"type": "module",
- "main": "./dist/index.cjs",
- "module": "./dist/index.mjs",
+ "main": "./dist/index.js",
+ "module": "./dist/index.js",
"exports": {
</file context>
Suggested change
| "main": "./dist/index.js", | |
| "main": "./dist/index.cjs", |
✅ Addressed in 265bd00
b304c85 to
d23d77e
Compare
d23d77e to
92e2cad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems like the unbuild issue. It's not happening in 1.4
Fixes: #5637
Summary by cubic
Switch core build to tsdown (rolldown) for faster, simpler builds. Unifies .js outputs and fixes internal imports to play nicely with bundlers.
Refactors
Dependencies