fix: typescript inference issue when declaration is enabled#2142
Closed
fix: typescript inference issue when declaration is enabled#2142
Conversation
Contributor
|
Review this PR on mrge.io |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
commit: |
| }, | ||
| "main": "./dist/index.cjs", | ||
| "module": "./dist/index.mjs", | ||
| "sideEffects": false, |
Contributor
There was a problem hiding this comment.
Adding sideEffects: false might cause issues if any plugins have actual side effects that should be preserved during tree-shaking
| } | ||
| }, | ||
| "./plugins/access": { | ||
| "./plugins/*": { |
Contributor
There was a problem hiding this comment.
Wildcards in exports paths may not be compatible with all bundlers and tools
| "solid-js/store", | ||
| "next/headers", | ||
| ...Object.keys(dependencies), | ||
| ...Object.keys(devDependencies), |
Contributor
There was a problem hiding this comment.
Including all devDependencies as externals might be overly broad as dev-only tools shouldn't typically be externalized in the build config.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2123