fix: replace remaining cookie 'options' references with 'attributes'

github-actions[bot] · himself65 · github-actions[bot] · commit f1d272b8c0f4 · 2026-01-14T21:58:11.000Z
- Fix last-login-method plugin to use authCookies.sessionToken.attributes
- Fix mcp and oidc-provider plugins to use 'attributes' in expireCookie calls
- Resolves TypeScript compilation errors after cookie refactoring

Co-authored-by: Alex Yang &lt;himself65@users.noreply.github.com&gt;
diff --git a/packages/better-auth/src/plugins/last-login-method/index.ts b/packages/better-auth/src/plugins/last-login-method/index.ts
@@ -153,7 +153,7 @@ export const lastLoginMethod = <O extends LastLoginMethodOptions>(
 								// Inherit cookie attributes from Better Auth's centralized cookie system
 								// This ensures consistency with cross-origin, cross-subdomain, and security settings
 								const cookieAttributes = {
-									...ctx.context.authCookies.sessionToken.options,
+									...ctx.context.authCookies.sessionToken.attributes,
 									maxAge: config.maxAge,
 									httpOnly: false, // Override: plugin cookies are not httpOnly
 								};
diff --git a/packages/better-auth/src/plugins/mcp/index.ts b/packages/better-auth/src/plugins/mcp/index.ts
@@ -207,7 +207,7 @@ export const mcp = (options: MCPOptions) => {
 						}
 						expireCookie(ctx, {
 							name: "oidc_login_prompt",
-							options: { path: "/" },
+							attributes: { path: "/" },
 						});
 						const sessionCookie = parsedSetCookieHeader.get(cookieName)?.value;
 						const sessionToken = sessionCookie?.split(".")[0]!;
diff --git a/packages/better-auth/src/plugins/oidc-provider/index.ts b/packages/better-auth/src/plugins/oidc-provider/index.ts
@@ -403,7 +403,7 @@ export const oidcProvider = (options: OIDCOptions) => {
 						}
 						expireCookie(ctx, {
 							name: "oidc_login_prompt",
-							options: { path: "/" },
+							attributes: { path: "/" },
 						});
 						const sessionCookie = parsedSetCookieHeader.get(cookieName)?.value;
 						const sessionToken = sessionCookie?.split(".")[0]!;
@@ -583,7 +583,7 @@ export const oidcProvider = (options: OIDCOptions) => {
 					// Clear the cookie
 					expireCookie(ctx, {
 						name: "oidc_consent_prompt",
-						options: { path: "/" },
+						attributes: { path: "/" },
 					});
 
 					const value = JSON.parse(verification.value) as CodeVerificationValue;

Original file line number	Diff line number	Diff line change
`@@ -207,7 +207,7 @@ export const mcp = (options: MCPOptions) => {`
`207`	`207`	`}`
`208`	`208`	`expireCookie(ctx, {`
`209`	`209`	`name: "oidc_login_prompt",`
`210`		`- options: { path: "/" },`
	`210`	`+ attributes: { path: "/" },`
`211`	`211`	`});`
`212`	`212`	`const sessionCookie = parsedSetCookieHeader.get(cookieName)?.value;`
`213`	`213`	`const sessionToken = sessionCookie?.split(".")[0]!;`