Skip to content

Upgrade ASM to 7.2 in order to support Java 13#99

Merged
siordache merged 1 commit into
beryx:masterfrom
tobiasdiez:patch-2
Nov 10, 2019
Merged

Upgrade ASM to 7.2 in order to support Java 13#99
siordache merged 1 commit into
beryx:masterfrom
tobiasdiez:patch-2

Conversation

@tobiasdiez

Copy link
Copy Markdown
Contributor

Trying to use this plugin with Java 13 leads to the following error:

Caused by: java.lang.IllegalArgumentException: Unsupported class file major version 57
	at org.beryx.jlink.shadow.asm.ClassReader.<init>(ClassReader.java:184)
	at org.beryx.jlink.shadow.asm.ClassReader.<init>(ClassReader.java:166)
	at org.beryx.jlink.shadow.asm.ClassReader.<init>(ClassReader.java:152)
	at org.beryx.jlink.shadow.asm.ClassReader.<init>(ClassReader.java:273)
	at org.beryx.jlink.util.ModuleInfoAdjuster$_getAdjustedDescriptors_closure1.doCall(ModuleInfoAdjuster.groovy:56)
	at jdk.internal.reflect.GeneratedMethodAccessor90.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at org.beryx.jlink.util.Util$_scanJar_closure7$_closure18.doCall(Util.groovy:219)
	at org.beryx.jlink.util.Util$_scanJar_closure7$_closure18.call(Util.groovy)
	at org.beryx.jlink.util.Util$_scanJar_closure7.doCall(Util.groovy:218)
	at jdk.internal.reflect.GeneratedMethodAccessor89.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at org.beryx.jlink.util.Util.scanJar(Util.groovy:217)
	at org.beryx.jlink.util.Util.scan(Util.groovy:199)
	at org.beryx.jlink.util.ModuleInfoAdjuster.getAdjustedDescriptors(ModuleInfoAdjuster.groovy:52)
	at org.beryx.jlink.util.ModuleInfoAdjuster$getAdjustedDescriptors.call(Unknown Source)
	at org.beryx.jlink.impl.PrepareModulesDirTaskImpl$_adjustModuleDescriptors_closure6.doCall(PrepareModulesDirTaskImpl.groovy:70)
	at jdk.internal.reflect.GeneratedMethodAccessor91.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)

	at org.beryx.jlink.impl.PrepareModulesDirTaskImpl.adjustModuleDescriptors(PrepareModulesDirTaskImpl.groovy:68)

Since version 7.1 ASM does support Java 13, thus the upgrade should fix this problem.

@siordache siordache merged commit f6d3cc5 into beryx:master Nov 10, 2019
@tobiasdiez tobiasdiez deleted the patch-2 branch November 10, 2019 19:24
@siordache

Copy link
Copy Markdown
Member

Thanks for your PR! It's included in 2.16.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants