Skip to content

Rename output to dest for jpackage task#91

Merged
DJViking merged 4 commits into
beryx:masterfrom
tobiasdiez:patch-1
Oct 2, 2019
Merged

Rename output to dest for jpackage task#91
DJViking merged 4 commits into
beryx:masterfrom
tobiasdiez:patch-1

Conversation

@tobiasdiez

@tobiasdiez tobiasdiez commented Oct 2, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

The latest version of jpackage was just made public and there the --output argument was renamed to --dest. See https://openjdk.java.net/jeps/343. I've not yet tested if these were the only breaking changes. See here for a list of all changes: https://mail.openjdk.java.net/pipermail/core-libs-dev/2019-October/062682.html

@tobiasdiez tobiasdiez mentioned this pull request Oct 2, 2019
Merged
6 tasks
@siordache

siordache commented Oct 2, 2019

Copy link
Copy Markdown
Member

@tobiasdiez Thanks a lot for the PR!

It seems that there is another breaking cnange in this release: the --identifier option was dropped. Can you please check if this is really the case and, if necessary, remove this line?

@siordache siordache mentioned this pull request Oct 2, 2019
Closed
@DJViking

DJViking commented Oct 2, 2019 •
edited
Loading

Copy link
Copy Markdown
Collaborator

It seems that there is another breaking cnange in this release: the --identifier option was dropped.

Yes it has been removed from jpackage.

@tobiasdiez

tobiasdiez commented Oct 2, 2019

Copy link
Copy Markdown
Contributor Author

Ok, I've removed it.

@DJViking DJViking merged commit ba2cb46 into beryx:master Oct 2, 2019
@tobiasdiez

tobiasdiez commented Oct 2, 2019

Copy link
Copy Markdown
Contributor Author

Thanks for the quick merge. Is there a way to convinently use the latest snapshot containing this fix?

@siordache

siordache commented Oct 2, 2019

Copy link
Copy Markdown
Member

Release 2.16.0 contains this PR and an additional small change.

@tobiasdiez @DJViking I only tested on Windows, with two small projects, so please check if it also works on other platforms and with your own projects. Thanks for your help!

@tobiasdiez

tobiasdiez commented Oct 3, 2019

Copy link
Copy Markdown
Contributor Author

Thanks for the release! It's working for us on windows, Mac and Linux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tobiasdiez @siordache @DJViking