VpnService improvements#58
Merged
Merged
Conversation
Closed
markpash
approved these changes
Feb 21, 2024
markpash
left a comment
Member
There was a problem hiding this comment.
The changes look reasonable to me. I'll merge this and hopefully run some tests.
I'll also probably enable CI builds on push to the main branch so we can see where builds fail. And the apk should get uploaded so we can play with what's currently on main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made some improvements to the connection state handling. Current connection state was being published to every registered observer whenever a new observer was being registered due to an oversight.
Created a base activity that observes connection state. This is done to prevent service binding logic duplication in every single activity.