fix(pi): handle ctrl-c as overlay cancel#16
Merged
benvinegar merged 2 commits intomainfrom Apr 26, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ctrl+Cin the Pi termDRAW overlay as an explicit cancel actionCtrl+CCtrl+Cfrom bubbling out and leavingopentui-islandwaiting on a dead sidecarDetails
Previously, the overlay only treated
Ctrl+Qas the normal cancel shortcut during steady-state use. PressingCtrl+Ccould escape to the host instead of closing the overlay cleanly, which could leave the sidecar client reporting errors like:OpenTUI sidecar exited unexpectedly while waiting for resizeThis change makes the Pi overlay intercept
Ctrl+Cthe same way it already handlesCtrl+Q, so canceling termDRAW closes the surface deterministically.Testing
cd packages/pi && bun run typecheckcd packages/pi && bun run smoke:piThis PR description was generated by Pi using OpenAI o3