Skip to content

fix: rm duplicate external link icon#218

Merged
stordahl merged 1 commit intomainfrom
stordahl/external-link-regression
Aug 25, 2025
Merged

fix: rm duplicate external link icon#218
stordahl merged 1 commit intomainfrom
stordahl/external-link-regression

Conversation

@stordahl
Copy link
Copy Markdown
Collaborator

@stordahl stordahl commented Aug 25, 2025

In #216 I introduced a regression where ExternalLink icons were rendered for all labels, not just those that match the previous regex

@stordahl stordahl marked this pull request as ready for review August 25, 2025 00:31
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.31%. Comparing base (d9d6cb2) to head (2b81e5d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #218      +/-   ##
==========================================
- Coverage   78.35%   78.31%   -0.05%     
==========================================
  Files          51       51              
  Lines        3941     3933       -8     
  Branches      520      520              
==========================================
- Hits         3088     3080       -8     
  Misses        844      844              
  Partials        9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@stordahl stordahl merged commit dbb4d61 into main Aug 25, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant