Skip to content

custom 404 page done#206

Merged
stordahl merged 2 commits intobenvinegar:mainfrom
heyysiri:custom-404-page
Jul 30, 2025
Merged

custom 404 page done#206
stordahl merged 2 commits intobenvinegar:mainfrom
heyysiri:custom-404-page

Conversation

@heyysiri
Copy link
Copy Markdown
Contributor

Fixes #201
Looks like this with the chart icons bouncing:
Screenshot 2025-07-27 141321

@benvinegar
Copy link
Copy Markdown
Owner

Needs to intentionally match the style of the site, use the site's icons (instead of randomly generated ones), etc.

@stordahl
Copy link
Copy Markdown
Collaborator

@heyysiri I agree with Ben - here's some design/content feedback

  • container background should be transparent or match the background color of the page
  • icons should be removed
  • "Looks like these charts..." text should be removed

Copy link
Copy Markdown
Collaborator

@stordahl stordahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @heyysiri - thank you!

@stordahl stordahl merged commit f2a3816 into benvinegar:main Jul 30, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add custom 404 Page

3 participants