Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #205 +/- ##
==========================================
+ Coverage 79.77% 79.93% +0.15%
==========================================
Files 43 43
Lines 3353 3359 +6
Branches 417 421 +4
==========================================
+ Hits 2675 2685 +10
+ Misses 670 666 -4
Partials 8 8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
this looks great - exactly what I wanted. Hopefully @benvinegar will merge next time he does work on counterscale |
Collaborator
Author
|
@wesbos Great! I've joined Ben as a maintainer of counterscale, so I'll make sure this gets into the next release. Thanks again for reporting this! |
|
oh dang, amazing! Thanks a ton! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #188
Counterscale.init()instead of throwing when a client is already initializedCounterscale.isInitialized()- a convenience method if you need to know if a client exists but don't need the client itselfCounterscale.getInitializedClient()- returns a client if one exists, otherwise returns undefinedCounterscale.*methods in the root README