Skip to content

fix: Render version at the bottom of layout (again)#176

Merged
benvinegar merged 3 commits intomainfrom
fix-version
Mar 25, 2025
Merged

fix: Render version at the bottom of layout (again)#176
benvinegar merged 3 commits intomainfrom
fix-version

Conversation

@benvinegar
Copy link
Copy Markdown
Owner

@benvinegar benvinegar commented Mar 23, 2025

It's a little more sophisticated this time:

If deployed from a clone (i.e. during development), will use the HEAD git sha as "version". Clicking the link brings you to that commit on GitHub.

If deployed using the CLI (e.g. via npx @counterscale/cli install), will use the current release version as declared in package.json (e.g. v3.0.0). Clicking the link brings you to the release notes on GitHub for that release.

Fixes #174

  • Before merging, need to verify version behavior from the CLI and from a new package.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 23, 2025

Codecov Report

Attention: Patch coverage is 35.00000% with 26 lines in your changes missing coverage. Please review.

Project coverage is 80.46%. Comparing base (56de0bb) to head (6d96e27).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/server/app/root.tsx 35.29% 22 Missing ⚠️
packages/cli/src/install.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #176      +/-   ##
==========================================
- Coverage   80.98%   80.46%   -0.53%     
==========================================
  Files          42       42              
  Lines        3140     3169      +29     
  Branches      380      381       +1     
==========================================
+ Hits         2543     2550       +7     
- Misses        589      611      +22     
  Partials        8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@benvinegar benvinegar merged commit 1cf8f18 into main Mar 25, 2025
3 checks passed
@benvinegar benvinegar deleted the fix-version branch March 25, 2025 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Version no longer visible on deployed app

1 participant