Fix ripple layer for MenuItem header style not respecting RecognizesAccessKey.#60
Merged
benruehl merged 2 commits intobenruehl:masterfrom Feb 1, 2020
sirtony:master
Merged
Fix ripple layer for MenuItem header style not respecting RecognizesAccessKey.#60benruehl merged 2 commits intobenruehl:masterfrom sirtony:master
benruehl merged 2 commits intobenruehl:masterfrom
sirtony:master
Conversation
Owner
|
Good find, thanks for fixing it right away! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default style for
MenuItemheaders without the ripple layer correctly setsRecognizeAccessKey(MenuItem.xaml#L140@5515312), however the ripple layer header template does not (MenuItem.xaml#L88@5515312), resulting in menu items with no children and a keyboard accelerator key displaying a literal underscore on mouse down.