.NET 5 fix singlefile apps crashing on fetching app icon#164
.NET 5 fix singlefile apps crashing on fetching app icon#164benruehl merged 3 commits intobenruehl:masterfrom
Conversation
|
Is there anything i can do, to get this merged? |
|
Thanks for contributing! |
|
Hi, thanks for taking a look at this. There was indeed a bug here. I've updated the PR accordingly. Could you take a look again? Also can you clarify what Demo-App and Icon you were referring to? Even with my most recent changes, i fail to find the difference, that should be visibile, in the AdoniUI.Demo? |
|
Thanks for updating, I'll take a look. And yes, I am referring to the AdonisUI.Demo app. By default, you don't see it because the title bar is in the |

Fixes #159
When a application using AdonisUI uses .net5 was compiled as
<SelfContained>true</SelfContained>and<PublishSingleFile>true</PublishSingleFile>then
Assembly.GetEntryAssembly()?.ManifestModule.FullyQualifiedNamewon't return a valid filename.I replaced that call with
and also added a check for the returned path actually pointing to a valid file, just in case things change again in the future.