Skip to content

Address Allow hiding of the window title in the title bar #127#128

Merged
benruehl merged 3 commits intobenruehl:masterfrom
marcinkurek:master
Oct 17, 2020
Merged

Address Allow hiding of the window title in the title bar #127#128
benruehl merged 3 commits intobenruehl:masterfrom
marcinkurek:master

Conversation

@marcinkurek
Copy link
Copy Markdown
Contributor

@marcinkurek marcinkurek commented Oct 16, 2020

This PR adds a TitleVisibility property to AdonisWindow and maximizes the usable area for TitleBarContent:

both

icon

title

none

@marcinkurek marcinkurek mentioned this pull request Oct 16, 2020
Closed
@benruehl benruehl self-requested a review October 17, 2020 16:11
@benruehl benruehl added the enhancement New feature or request label Oct 17, 2020
@benruehl benruehl added this to the Release 1.16.1 milestone Oct 17, 2020
@benruehl benruehl linked an issue Oct 17, 2020 that may be closed by this pull request
Allow hiding of the window title in the title bar #127
Closed
benruehl
benruehl approved these changes Oct 17, 2020
View reviewed changes
Copy link
Copy Markdown
Owner

@benruehl benruehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks a lot.

@benruehl benruehl merged commit 7f7ff0e into benruehl:master Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benruehl benruehl benruehl approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

Release 1.17

Development

Successfully merging this pull request may close these issues.

Allow hiding of the window title in the title bar

2 participants

@marcinkurek @benruehl