[BUGFIX] AdonisWindow not being able to handle setting the IconProperty manually#100
Merged
benruehl merged 1 commit intobenruehl:masterfrom Jun 9, 2020
Merged
Conversation
Owner
|
Although I don't have an actual use case for this on my mind, it makes sense to me that this should be supported. Thanks a lot for contributing again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When setting the IconProperty of a (Adonis-)Window instance, a
System.UriFormatExceptionis being thrown from this line, when theToStringmethod of that object doesnt evaluate to a valid Uri.Such is the case for objects that represent an actual image, such as any class that derives from
ImageSource.This PR takes those cases into account and skips the fallback logic that tries turning them into valid URIs.