Print class property definite assignment assertions#1013
Merged
eventualbuddha merged 1 commit intobenjamn:masterfrom Apr 27, 2022
Merged
Print class property definite assignment assertions#1013eventualbuddha merged 1 commit intobenjamn:masterfrom
eventualbuddha merged 1 commit intobenjamn:masterfrom
Conversation
Collaborator
|
Thanks! Mind adding a test? |
Contributor
Author
|
@eventualbuddha Sure, could you point me to the location where I should put this? |
Collaborator
Maybe here? |
96cf8d0 to
99c4fb9
Compare
Contributor
Author
|
@eventualbuddha I checked I put the tests inside |
Contributor
Author
|
I had to use import * as assert from "assert";
import * as ast from "ast-types";
const b = ast.builders;
const n1 = Object.assign(
b.classProperty(
b.identifier("key"),
null
),
{ definite: true }
);
const n2 = b.classProperty.from({
key: b.identifier("key"),
value: null,
definite: true,
});
assert.deepStrictEqual(n1, n2); |
99c4fb9 to
e71ab9b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1012
This PR makes the printer aware of
definiteproperty inClassPropertyAST node, printing!whentrue