Fix UserDict move in Python2#365
Merged
Merged
Conversation
instances of UserDict.UserDict are not iterable but instances of collections.UserDict are iterable
Owner
|
Thanks for the PR. I don't really understand the point of having a attribute |
Contributor
Author
|
Thanks for the review, @benjaminp. I can revert a5610fc if it is a blocker. |
This reverts commit a5610fc.
Contributor
Author
|
Ok, @benjaminp , a5610fc is now reverted and PR no longer adds |
benjaminp
approved these changes
Nov 21, 2021
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The current implementation of
UserDictattribute mapsUserDict.UserDicttocollections.UserDict:From the Python 2.7 documentation:
This limitation does not exist in Python3.
As a result,
sixintroduces a bug in Python2.Reproduction steps:
PY3output:PY2output:Solution
This PR addresses it by updating
UserDictattribute to mapUserDict.IterableUserDictin Python2 andcollections.UserDictin Python3.PR also adds moves for
IterableUserDictwhich maps to the same attribute asUserDict.PR fixes #281 issue