Skip to content

Add github workflow#362

Closed
cristianMeli wants to merge 28 commits into
benjaminp:mainfrom
cristianMeli:github-actions
Closed

Add github workflow#362
cristianMeli wants to merge 28 commits into
benjaminp:mainfrom
cristianMeli:github-actions

Conversation

@cristianMeli

Copy link
Copy Markdown
Contributor

No description provided.

@benjaminp benjaminp left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for doing this.

"py-27",
"py-33",
"py-35",
]

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the other Python versions?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is still in progress, I will add the other Python versions.
I converted the PR to draft.

@cristianMeli cristianMeli marked this pull request as draft November 24, 2021 11:31
@cristianMeli

cristianMeli commented Dec 18, 2021

Copy link
Copy Markdown
Contributor Author

Hi @benjaminp so long!
I am catching up with this. I think it is almost ready.
It left test to publish a versión, here are some useful links to create the password and token necessary:

The condition to create a version is to push a tagged commit, I do not know how would you like to manage this.
Do you think that you could create these data to test upload a test version?

@cristianMeli cristianMeli marked this pull request as ready for review December 18, 2021 19:01
@benjaminp

Copy link
Copy Markdown
Owner

I added a PYPI_API_TOKEN secret for an account on the TestPyPI instance (test.pypi.org). Does that work for testing? I think it will probably ultimately fail because six on testpypi is registered to some other account, but maybe you can change the package name for testing purposes.

@Jamim Jamim left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @cristianMeli,

Thanks for this PR! I'm not related to six, but I believe this project needs this.
I see the PR was updated 2 years ago last time and it was almost ready to be merged. However, there were several Python releases since then.
Would you mind updating this PR to include modern versions of Python and also make some minor adjustments?

Thanks in advance!

Comment thread test_six.py
Comment on lines +1053 to +1057


def test_foo():
foo = "FOO"
assert foo == "FOO"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this was added for debug purposes and should be removed from the final version.

Suggested change
def test_foo():
foo = "FOO"
assert foo == "FOO"

container: true

steps:
- uses: actions/checkout@v2

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v4 is the latest version of actions/checkout currently.

Suggested change
- uses: actions/checkout@v2
- uses: actions/checkout@v4

needs: [build]

steps:
- uses: actions/checkout@v2

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v4 is the latest version of actions/checkout currently.

Suggested change
- uses: actions/checkout@v2
- uses: actions/checkout@v4

- uses: actions/checkout@v2

- name: Set up Python
uses: actions/setup-python@v2

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v5 is the latest version of actions/setup-python currently.

Suggested change
uses: actions/setup-python@v2
uses: actions/setup-python@v5



- name: Set up Python ${{ matrix.python }}
uses: actions/setup-python@v2

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v5 is the latest version of actions/setup-python currently.

Suggested change
uses: actions/setup-python@v2
uses: actions/setup-python@v5

@benjaminp

Copy link
Copy Markdown
Owner

I appreciate everyone's efforts on this, but I ended up going a different route.

@benjaminp benjaminp closed this Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants