fix: chalk platform undefined error by upgrading the version#332
fix: chalk platform undefined error by upgrading the version#332Methuselah96 merged 1 commit intobenjamine:masterfrom
Conversation
|
Hey @benjamine - Could you please take a look at this super tiny PR when you get a moment? |
|
@benjamine Gentle bump - Could you take a look at this or add me as a collaborator? I'm happy to help release this. |
There was a problem hiding this comment.
Thanks for the PR and sorry for the delay in getting this fixed!
I went ahead and downgraded chalk to 3.0.0 to avoid the breaking change of not supporting Node.js 8 in chalk 4.
I tested that console coloring still works using the docs/demo/consoledmo.js. I also tested that this fixes usage by Vite with a local app.
Ideally we would not be importing from chalk at all in a browser context, but that change is more complicated due to the older tech stack that jsondiffpatch currently uses. In the future we'll hopefully fix this by having a browser bundler-friendly ESM build, but that doesn't exist yet.
fixes #315
chalk@5.1.0? I'm playing it safe aschalk>=5is pure ESM and I have very little knowledge of how this library operates 😅