Fix incorrect matrix initialization#291
Merged
Methuselah96 merged 3 commits intobenjamine:masterfrom Aug 24, 2023
Merged
Conversation
Contributor
Author
|
@amiller-gh Why don't you send a pull request for these changes? That sounds like a great improvement! |
Methuselah96
approved these changes
Aug 24, 2023
Collaborator
Methuselah96
left a comment
There was a problem hiding this comment.
Thanks for the PR! Sorry for the delayed response.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Unless I am missing something, the initialization of the matrix in the LCS filter is wrong. It currently puts a number (length of first array + 1) into the matrix, then immediately overwrites it.
While this shouldn't produce any bugs, I found it a little confusing when reading the code. As I see it there are two potential fixes:
new Array(length)syntaxI assume the latter was the intention, so that's what the PR implements, but happy to change it if you want.